Test: Added PostUpgradeArb #1512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansteren
force-pushed
the
1497_post_upgrade
branch
from
b270e31 to
54e3b23
Compare
dansteren
force-pushed
the
1471_init_method_arb
branch
from
a1362ce to
704155e
Compare
dansteren
force-pushed
the
1497_post_upgrade
branch
from
3466e60 to
0b061c5
Compare
dansteren
force-pushed
the
1471_init_method_arb
branch
from
704155e to
0098380
Compare
dansteren
force-pushed
the
1497_post_upgrade
branch
from
0b061c5 to
16b7d39
Compare
dansteren
force-pushed
the
1471_init_method_arb
branch
from
0098380 to
7ec8bb8
Compare
dansteren
force-pushed
the
1497_post_upgrade
branch
from
16b7d39 to
654da5e
Compare
Open
4 tasks
lastmjs
requested changes
Jan 9, 2024
| name: `init method`, | ||
| test: async () => { | ||
| const actor = getActor('./tests/post_upgrade_method/test'); | ||
| const result = await actor.getPostDeployValues(); |
There was a problem hiding this comment.
I think this needs to be redone. The init method tests should be completely separate from the post upgrade tests. These tests should be almost identical to the actual init method tests, using the same global variables. We do not want the global variables for testing init and post_upgrade to be the same, otherwise you don't have a guarantee that a deploy occurred.
|
|
||
| runPropTests(CanisterArb(CanisterConfigArb)); | ||
|
|
||
| function generateGetPostDeployValuesCanisterMethod( |
There was a problem hiding this comment.
Is this how we did the getInitValues in the init method test?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of #1492 to add PostUpgrade tests to our canister methods.
Caution
Change the base of this brach to
mainbefore merging.Closes #1497